#4195: Poco::File::created() on macOS should use birthtime

pocoproject · Oct 18, 2023 · 51ba1be · 51ba1be
1 parent 7510c60
commit 51ba1be
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 8 deletions.
diff --git a/CHANGELOG b/CHANGELOG
@@ -194,10 +194,10 @@ Release 1.12.0 (2022-07-08)
 - GH #3665 MSVC does not properly recognize std version
 
 
-Release 1.11.8 (2023-10-16)
+Release 1.11.8 (2023-10-18)
 ===========================
 
-- GH #1372: Possible deadlock in SessionPool 
+- GH #1372: Possible deadlock in SessionPool
 - GH #4170: Poco::FileStream is always opened with std::ios::in | std::ios::out bug
 - GH #4169: Upgrade bundled zlib to 1.3.
 - GH #4171: Upgrade bundled sqlite to 3.43.1
@@ -207,6 +207,7 @@ Release 1.11.8 (2023-10-16)
 - GH #4174: AbstractConfiguration: support Int16/UInt16 and Int32/UInt32
 - GH #4182: Util: Make load()/save()/clear() operations on configurations thread-safe
 - GH #4184: Poco::TemporaryFile: make filenames less predictable
+- GH #4195: Poco::File::created() on macOS should use birthtime
 
 
 Release 1.11.7 (2023-07-11)

diff --git a/Foundation/src/File_UNIX.cpp b/Foundation/src/File_UNIX.cpp
@@ -212,11 +212,7 @@ Timestamp FileImpl::createdImpl() const
 {
 	poco_assert (!_path.empty());
 
-#if defined(__APPLE__) && defined(st_birthtime) && !defined(POCO_NO_STAT64) // st_birthtime is available only on 10.5
-	struct stat64 st;
-	if (stat64(_path.c_str(), &st) == 0)
-		return Timestamp::fromEpochTime(st.st_birthtime);
-#elif defined(__FreeBSD__)
+#if defined(__FreeBSD__) || (defined(__APPLE__) && defined(_DARWIN_FEATURE_64_BIT_INODE))
 	struct stat st;
 	if (stat(_path.c_str(), &st) == 0)
 		return Timestamp::fromEpochTime(st.st_birthtime);

diff --git a/doc/99100-ReleaseNotes.page b/doc/99100-ReleaseNotes.page
@@ -209,7 +209,7 @@ AAAIntroduction
 
 !!Summary of Changes
 
-  - GH #1372: Possible deadlock in SessionPool 
+  - GH #1372: Possible deadlock in SessionPool
   - GH #4170: Poco::FileStream is always opened with std::ios::in | std::ios::out bug
   - GH #4169: Upgrade bundled zlib to 1.3.
   - GH #4171: Upgrade bundled sqlite to 3.43.1
@@ -219,6 +219,7 @@ AAAIntroduction
   - GH #4174: AbstractConfiguration: support Int16/UInt16 and Int32/UInt32
   - GH #4182: Util: Make load()/save()/clear() operations on configurations thread-safe
   - GH #4184: Poco::TemporaryFile: make filenames less predictable
+  - GH #4195: Poco::File::created() on macOS should use birthtime
 
 
 !!!Release 1.11.7