Fixes #154 Partition sizes smaller on AMIs #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @klobes5, thanks for the PR! Would you mind editing the PR comment to fill out the details? It helps us track and understand what is changing, why it's changing, what alternatives were considered, whether any issues are related, etc. Also, were you able to build this locally, successfully with this change? |
|
Hello @lorengordon, Fixed the comment. Yes I was able to build locally and use the custom image. @eseglem and I would like the official image to reflect this change so that the Vagrant box and AMI are identical. |
lorengordon
approved these changes
Mar 2, 2018
|
@klobes5 ok, thanks! I'll push a point update for the vagrant builder. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154 .
Changes offered/proposed in this pull request:
-This is so the Vagrant box partition sizes more closely resemble those used in the AMIs