fix: find blocks if fieldname is similiar to 'blocks' #6299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
|
@sneridagh @ichim-david do you think we could merge this one during Salamina sprint? |
ichim-david
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
@giuliaghisini I'm ok with the fix and merging for 18. Victor next :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed findBlocks because if we have a block with a property inside which name ends with 'blocks' the findBlocks function is called assuming that field contains something similar to volto's block, but it couldn't be.
For example, if we have some blocks with the property 'subblocks' inside that is simply an array of object (not volto's blocks) an error is thrown