Rename constants/Language module to the right suffix, and other actions to make ESM bundlers happy.
#6130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
|
@stevepiercy a bunch of my crappy english upgrade guide paragraphs. |
ichim-david
approved these changes
Jun 27, 2024
There was a problem hiding this comment.
@sneridagh I think this change is fine, waiting for @stevepiercy magic for docs check
stevepiercy
requested changes
Jun 27, 2024
stevepiercy
added a commit
to plone/documentation
that referenced
this pull request
Jun 27, 2024
They may be crappy, but they are my favorite, just like I'm my parents' favorite son. 😉 |
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh
changed the title
constants/Language module to the right suffix, and other actions to make ESM bundlers happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://volto--6130.org.readthedocs.build/