Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permission inconsistency between authenticating with (Zope) admin using basic auth and token #168

Closed
sneridagh opened this issue Dec 5, 2016 · 3 comments

Comments

@sneridagh
Copy link
Member

I guess it's not important, but maybe this hides something else that is. So here it goes.

I discovered that the use case when you auth with the admin Zope user via token, the user have a different set of permissions (not roles) than when it's authenticated via basic auth.

This make any sense for you? I haven't been able to reproduce it with a test. I stumbled into this when trying to change workflow of an item with the admin user via token in an app. It didn't allowed me, because in that context the user lack the Review content permission!

@buchi @lukasgraf @timo any insights?

@sneridagh sneridagh changed the title Permission inconsistency when authenticating with (Zope) admin using basic auth and token Permission inconsistency between authenticating with (Zope) admin using basic auth and token Dec 5, 2016
@buchi
Copy link
Member

buchi commented Dec 5, 2016

Seems to be the same issue as in #127.

The problem is that the admin user is defined in the root acl_users folder but the JWT plugin is installed in the acl_users folder of the Plone site. The user only gets roles from the acl_users folder he got authenticated in. When authenticated by the JWT plugin, the admin user doesn't get any roles from the root acl_users folder.

I think we should remove the support for authenticating users that are not defined in the same acl_users folder as the JWT plugin because it doesn't work properly. This also means that you will no longer be able to authenticate as admin user with a JWT token. A workaround would be to install the JWT plugin in the root acl_users folder. However the current implementation relies on plone.keyring which doesn't work outside of a Plone site.

@tomgross
Copy link
Member

tomgross commented Dec 6, 2016

I have seen a security issue in collective.solr which is probably related. collective/collective.solr#150

@tisto
Copy link
Sponsor Member

tisto commented Feb 27, 2017

Will close this issue for #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants