Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blobs in persistent tiles are not versioned / versioning content with blobs in persistent tiles result empty blobs in version history #80

Closed
datakurre opened this issue May 21, 2015 · 4 comments

Comments

@datakurre
Copy link
Member

Each CMFEditions' version of a content with persistent tiles with blobs, will create a new empty blob into filesystem for each found blob. E.g. with persistent image tile, a new version will result one empty blob for the image blob itself and another for its imagescale blob.

This should be fixed by implementing a such new modifier for CMFEditions, which would somehow handle blobs in annotations.

@datakurre datakurre changed the title Blobs in persistent tiles are not versioned Blobs in persistent tiles are not versioned / versioning content with persistent tiles result empty blobs May 22, 2015
@datakurre datakurre added this to the 1.1.0 milestone May 22, 2015
@datakurre datakurre changed the title Blobs in persistent tiles are not versioned / versioning content with persistent tiles result empty blobs Blobs in persistent tiles are not versioned / versioning content with blobs in persistent tiles result empty blobs May 22, 2015
@datakurre
Copy link
Member Author

/cc @hvelarde @cguardia @ericof

@datakurre
Copy link
Member Author

The actual issue here seem to be that deepcopying a blob results a new blob with zero data (bug or a feature of ZODB blob support?). And CMFEditions does its default versioning with deepcopy.

To reproduce:

  1. create a new Plone site with Mosaic
  2. add a new page with image tile and save the page
  3. blobdirectory should contain 2 blobs, one for the image and another for its scale
  4. edit page and save without changes
  5. blobdirectory should contain 4 blobs, two of them being zero sized

(Or such copy.deepcopy and commit some blob anywhere.)

Not sure, what our CMFEditions' modifier(s) should do or where it should be located.

@datakurre
Copy link
Member Author

For those, who want to dig into Plone versioning history, Nathan had minimal example for checking (and deleting) annotations of some object history:

http://stackoverflow.com/questions/10413409/cleaning-up-annotations-in-plones-cmfeditions-history-objects

@datakurre datakurre modified the milestones: 1.0.0, 1.1.0 May 25, 2015
@datakurre datakurre changed the title Blobs in persistent tiles are not versioned / versioning content with blobs in persistent tiles result empty blobs Blobs in persistent tiles are not versioned / versioning content with blobs in persistent tiles result empty blobs in version history May 26, 2015
@jpgimenez jpgimenez self-assigned this Sep 15, 2015
@datakurre datakurre modified the milestones: 1.2.0, 1.0.0 Apr 11, 2016
@datakurre
Copy link
Member Author

@esteele This is the versioning related blocker, which we discussed earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants