api.content.create fails to create a Plone4 AT Collection

[gbastien]

Hi everybody, @david-batranu

it fails in archetypes/querywidget/widget.py because the form given to process_form is {None: None} and values are not iterable.

This is due to a recent change, so either we change {None: None} to {'': ''} or we have to change archetypes.querywidget. Would {'': ''} sove your problem @david-batranu because it solves our ;-)

Thank you!

Gauthier

[hvelarde]

please be careful when fixing this or we could find an issue similar with the one I described in #407.

[gbastien]

Hi @hvelarde

I will add a test to plone.api showing the issue. Actually a simple create fails, we could also fix it in archetypes.querywidget but that does not seems correct to me. I will add a test that creates every ATCT default types.

Thank you for advice,

Gauthier

[hvelarde]

@gbastien we already created a failing test on the referenced pull request.

[david-batranu]

@gbastien A lot of time has passed, and don't remember exactly why I chose {None: None} as the "empty" value.

The purpose of the fix was for the if in BaseObject.process_form to pass, so that form = values instead of getting polluted by the request.form data. Looks like {'': ''} would pass this check as well. I'm not sure of any side-effects. I guess if the tests pass, it's ok :)

All of my findings are described on #99 (comment)

[gbastien]

@david-batranu

thank you for feedback, I think {'':''} will have the same behavior and it solves the problem... I proposed this change to @idgserpro and @hvelarde

Gauthier

[hvelarde]

fixed in #414