Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated menu item on toolbars #1007

Closed
hvelarde opened this issue Sep 16, 2015 · 8 comments
Closed

Duplicated menu item on toolbars #1007

hvelarde opened this issue Sep 16, 2015 · 8 comments
Labels
04 type: enhancement 99 tag: UX Accessibility Issues that specifically impact a11y
Milestone

Comments

@hvelarde
Copy link
Member

When you select one of the options of the menu you will see the title of the option duplicated as the first item on the list; this happens in both versions:

selection_006

selection_007

selection_004

selection_005

@davilima6
Copy link
Member

+1. I think that was useful when "More options" toolbar icon brought both Portlet management and Display menu links.

@ichim-david
Copy link
Sponsor Member

@hvelarde I am not so bothered about this. As I've mentioned in #950 you could easily hide the extra header with a css rule.

Why I still think it's useful to have is in this situation:

  • You are with the top toolbar and you use the content-menus which will crop the full title.
    At least in the dropdown the title is visible

See screenshot for better understanding
extra-header

@hvelarde
Copy link
Member Author

@ichim-david I think it would be better to replace those with tooltips as @davilima6 suggested in some other issue.

@davilima6
Copy link
Member

davilima6 commented Sep 16, 2015

I see, @ichim-david. In that case I believe we'd be good with hiding the duplicate header when toolbar is expanded and thus able to display its label.:

.plone-toolbar-expanded .plone-toolbar-submenu-header { display: none; }

Would you agree?

@ichim-david
Copy link
Sponsor Member

@davilima6 yes this could be an easy fix for this problem since it's really on the expanded section that it really feels out of place because of the "duplicated" content.

Any of you could commit such a hiding if there is consent from others as well that this is really bothersome and needs to go away.

@polyester
Copy link
Sponsor Member

Give me some time to pingpong this to some screenreader users; tooltips are not always as well supported whereas hiding them with CSS could be an easier way out for those who feel bothered by it.

@polyester polyester modified the milestones: Plone 5.0.x, Plone 5.0 Sep 19, 2015
@polyester polyester added 99 tag: UX Accessibility Issues that specifically impact a11y 04 type: enhancement and removed 01 type: bug labels Sep 19, 2015
@hvelarde hvelarde mentioned this issue Sep 22, 2015
19 tasks
@polyester
Copy link
Sponsor Member

polyester commented May 8, 2016

Tooltips are not well supported for a11y, and having the menu title in the submenu can also be used to have a complete menu title for languages that can only have an abbreviated version in the toolbar; this also helps those with cognitive issues.

I would be hesitant to remove. If your site does not require strict a11y adherence, it's a display: none away for your theming person to remove them, if they bother you esthetically.

@davisagli
Copy link
Sponsor Member

This didn't reach a clear conclusion and hasn't been touched in a few years. I'll close it but feel free to reopen.

@davisagli davisagli closed this as not planned Won't fix, can't repro, duplicate, stale Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
04 type: enhancement 99 tag: UX Accessibility Issues that specifically impact a11y
Projects
None yet
Development

No branches or pull requests

5 participants