Use url config value to generate disk url #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to set a custom url for a disk. This feature has landed on laravel 5.3, and this commit allows to use it on any compatible version. See laravel/framework#16281 for details and use cases.
|
Looks good! |
|
Just thought of something. Could this apply to cloud disks as well? |
|
I'm not sure, I've never used cloud drivers. I know that laravel's adapter supports it in some cases. See https://github.com/laravel/framework/blob/5.3/src/Illuminate/Filesystem/FilesystemAdapter.php#L279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to set a custom url for a disk.
This feature has landed on laravel 5.3, and this commit allows to use
it on any compatible version.
See laravel/framework#16281 for details and use
cases.