[Fixed] Use relative path to working directory for maven wrapper command

[jbmgrtn]

Resolves #889

[pivotal-cla]

@jbmgrtn Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

[cf-gitbot]

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

[jbmgrtn]

Do I have to sign the CLA?
Is this considered as being an obvious fix?

[jbmgrtn]

Please be indulgent, I don't know Ruby nor the best practices and code guidelines on your project.
Anyway, this project is well organized and written so it was not that hard on my side to find where was the problem and came up with a fix.

[xtreme-shane-lattanzio]

Hey @jbmgrtn and thanks for the PR! This looks good to me. As for ruby code cleanup, we actually run rubocop to do that. You can run rubocop in the root directory to see whats wrong or rubocop -a to have the issues auto fixed. Looking at the pipeline, the only issue is

Offenses:

lib/license_finder/package_managers/maven.rb:37:81: C: [Correctable] Style/Semicolon: Do not use semicolons to terminate expressions.
      wrapper = File.join(project_path, Platform.windows? ? 'mvnw.cmd' : 'mvnw');

I think the fix is trivial enough but to be safe, is it an issue to sign the CLA? It is basically just saying you do not own the change and are donating it to the project.

Once we have the pipeline green I'll merge this in!

[xtreme-shane-lattanzio]

Hey @jbmgrtn and thanks for the PR! This looks good to me. As for ruby code cleanup, we actually run rubocop to do that. You can run rubocop in the root directory to see whats wrong or rubocop -a to have the issues auto fixed. Looking at the pipeline, the only issue is

Offenses:

lib/license_finder/package_managers/maven.rb:37:81: C: [Correctable] Style/Semicolon: Do not use semicolons to terminate expressions.
      wrapper = File.join(project_path, Platform.windows? ? 'mvnw.cmd' : 'mvnw');

I think the fix is trivial enough but to be safe, is it an issue to sign the CLA? It is basically just saying you do not own the change and are donating it to the project.

Once we have the pipeline green I'll merge this in!

[pivotal-cla]

@jbmgrtn Thank you for signing the Contributor License Agreement!