-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixed] Use relative path to working directory for maven wrapper command #890
[Fixed] Use relative path to working directory for maven wrapper command #890
Conversation
@jbmgrtn Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
Do I have to sign the CLA? |
Please be indulgent, I don't know Ruby nor the best practices and code guidelines on your project. |
Hey @jbmgrtn and thanks for the PR! This looks good to me. As for ruby code cleanup, we actually run rubocop to do that. You can run
I think the fix is trivial enough but to be safe, is it an issue to sign the CLA? It is basically just saying you do not own the change and are donating it to the project. Once we have the pipeline green I'll merge this in! |
1 similar comment
Hey @jbmgrtn and thanks for the PR! This looks good to me. As for ruby code cleanup, we actually run rubocop to do that. You can run
I think the fix is trivial enough but to be safe, is it an issue to sign the CLA? It is basically just saying you do not own the change and are donating it to the project. Once we have the pipeline green I'll merge this in! |
… and not current project
9c64805
to
89a9253
Compare
@jbmgrtn Thank you for signing the Contributor License Agreement! |
Resolves #889