-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 allow to specify cocoadpods acknowledgment through ENV #873
🔧 allow to specify cocoadpods acknowledgment through ENV #873
Conversation
etiennecadicidean
commented
Jan 19, 2022
> in multi projects folder of iOS projects, it looks like the cocoapods plugin is unable to find the proper Pods-...-acknowledgments.plist file. As it takes only the 1st item of the dir, We should be able to also specify the one we want trought an environment variable ACKNOWLEDGEMENT_PATH just like what it is done in the SPM plugin where we do need to specify the environment variables for DerivedDatas & Package.resolved files.
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
@etiennecadicidean Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@etiennecadicidean Thank you for signing the Contributor License Agreement! |
Not sure why the bundle install step fails for some jruby tests on concourse-ci/ruby-jruby-9.2.14.0 it has nothing to do with my minor changes and I guess it fails on the main branch as well. |
Hi @etiennecadicidean , the PR looks good overall. The only change I would suggest is expose this new environment variable, either though the README, or through a raise error (similar to spm), or both. We want to make sure everyone is aware of this new feature. Do not worry about jruby as that is not a blocking test as we have not had the bandwidth yet to investigate the failing tests. |
@xtreme-jason-smith as the variable is completely optional and can help in very specific situations I only added additional informations in the README.md ! Thank you for your cutting comments on all my PRs 👍 |
Hey @etiennecadicidean ! Dont worry about the jruby stuff. It has been failing for a while and we will be removing it from our pipelines soon. We are just fixing up our CI and will merge this in. Thanks again!! |