Fixup the dependency line matching #771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this issue while running some tests. I must have always fetched deps before running LicenseFinder prior to these changes.
To reproduce prior to this PR, run the following command on the
master
branch:Error:
You will see an error concerning a line that begins with
DEP
. This is because the--prepare
argument is not specified, so themake QUERY=... query-deps
call out will actually fetch the deps, resulting in output that doesn't match the expectation for a dependency.It can be fixed by...
--prepare
argumentcc @xtreme-shane-lattanzio @gerhard