Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

best-practice: support extra strategy for fine-tuning the performance in massive regions #18221

Merged
merged 11 commits into from
Jul 12, 2024
Merged

best-practice: support extra strategy for fine-tuning the performance in massive regions #18221

merged 11 commits into from
Jul 12, 2024

Conversation

qiancai
Copy link
Collaborator

@qiancai qiancai commented Jul 12, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-ok-to-test translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Jul 12, 2024
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 12, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2024
@qiancai
Copy link
Collaborator Author

qiancai commented Jul 12, 2024

/cc @LykxSassinator

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2024

@qiancai: GitHub didn't allow me to request PR reviews from the following users: LykxSassinator.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @LykxSassinator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LykxSassinator
LykxSassinator reviewed Jul 12, 2024
View reviewed changes
Copy link
Contributor

@LykxSassinator LykxSassinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

best-practices/massive-regions-best-practices.md Outdated Show resolved Hide resolved
best-practices/massive-regions-best-practices.md Outdated Show resolved Hide resolved
qiancai and others added 2 commits July 12, 2024 17:08
@qiancai @LykxSassinator
Update best-practices/massive-regions-best-practices.md
daceef0 
Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
@qiancai @LykxSassinator
Update best-practices/massive-regions-best-practices.md
c704705 
Co-authored-by: lucasliang <nkcs_lykx@hotmail.com>
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2024

@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-12 09:24:49.742188452 +0000 UTC m=+311.733129923: ☑️ agreed by hfxsd.

@qiancai qiancai removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit de318d1 into pingcap:master Jul 12, 2024
9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #18226.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 12, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #18227.

This was referenced Jul 12, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #18228.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #18229.

This was referenced Jul 12, 2024
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18230.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18231.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 12, 2024
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 12, 2024
@qiancai @ti-chi-bot
This is an automated cherry-pick of pingcap#18221
71702ce 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 12, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #18232.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 12, 2024
@ti-chi-bot
best-practice: support extra strategy for fine-tuning the performance…
d0a7ae2 
… in massive regions (#18221) (#18231)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 12, 2024
@ti-chi-bot
best-practice: support extra strategy for fine-tuning the performance…
6378593 
… in massive regions (#18221) (#18230)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 12, 2024
@ti-chi-bot
best-practice: support extra strategy for fine-tuning the performance…
0e3a0b8 
… in massive regions (#18221) (#18227)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 12, 2024
@ti-chi-bot
best-practice: support extra strategy for fine-tuning the performance…
d278a22 
… in massive regions (#18221) (#18229)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 12, 2024
@ti-chi-bot
best-practice: support extra strategy for fine-tuning the performance…
5591165 
… in massive regions (#18221) (#18228)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 16, 2024
@ti-chi-bot
best-practice: support extra strategy for fine-tuning the performance…
ba28bd1 
… in massive regions (#18221) (#18226)
ti-chi-bot bot pushed a commit that referenced this pull request Jul 16, 2024
@ti-chi-bot
best-practice: support extra strategy for fine-tuning the performance…
3b926b3 
… in massive regions (#18221) (#18232)
qiancai added a commit to qiancai/docs that referenced this pull request Jul 16, 2024
@qiancai
best-practice: support extra strategy for fine-tuning the performance…
54c7268 
… in massive regions (pingcap#18221)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LykxSassinator LykxSassinator LykxSassinator approved these changes

@hfxsd hfxsd hfxsd approved these changes

Assignees
No one assigned
Labels
approved lgtm needs-1-more-lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-ok-to-test size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qiancai @ti-chi-bot @LykxSassinator @hfxsd