Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] fix 16032 Debug TiDB Cloud Documentation: Connect to TiDB with DBeaver #16095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Doc] fix 16032 Debug TiDB Cloud Documentation: Connect to TiDB with DBeaver #16095

wants to merge 1 commit into from
+0 −0

Conversation

enkilee
Copy link
Contributor

@enkilee enkilee commented Jan 11, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

fix issue16032 #16032

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cofyc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added contribution Indicates that the PR was contributed by an external member. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2024
@enkilee
Copy link
Contributor Author

enkilee commented Jan 11, 2024

/label 2024-tidb-docs-dash

@ti-chi-bot ti-chi-bot bot added the 2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. label Jan 11, 2024
dveeden
dveeden reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give some more information on what this PR fixes exactly? Is it the change from MySQL Connector/J 8.1.0 to 8.2.0?

media/develop/dbeaver-connection-test.jpg Show resolved Hide resolved
@qiancai qiancai linked an issue Jan 11, 2024 that may be closed by this pull request
Debug TiDB Cloud Documentation: Connect to TiDB with DBeaver #16032
Open
@qiancai qiancai added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Jan 11, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 11, 2024
@qiancai qiancai removed needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. area/tidb-cloud This PR relates to the area of TiDB Cloud. translation/no-need No need to translate this PR. labels Jan 11, 2024
@ti-chi-bot ti-chi-bot bot added the missing-translation-status This PR does not have translation status info. label Jan 11, 2024
@qiancai qiancai added translation/doing This PR's assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jan 11, 2024
@qiancai qiancai requested a review from Icemap January 11, 2024 07:41
@Icemap
Copy link
Member

Icemap commented Jan 30, 2024

Hi, @enkilee. Thanks for updating the captures.
However, here are a little bit of consistency issues that need to be changed. I'll show you some examples.

  1. Pixelated mode

    • Original capture
      Screenshot 2024-01-30 at 15 22 11
    • New capture
      Screenshot 2024-01-30 at 15 23 36

  2. Size (We don't need to be perfectly the same, but proximity at least)

    • Original capture: W: 1604px | H: 1300px
    • New capture: W: 1019px | H: 660px

  3. OS (Optional)

    • Original capture: MacOS
    • New capture: Windows

I think once we fix them, it will be ready for updating and merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dveeden dveeden dveeden left review comments

@Icemap Icemap Awaiting requested review from Icemap

Assignees

@Icemap Icemap

Labels
2024-tidb-docs-dash This issue or PR is included in the 2024 TiDB Docs Dash event. contribution Indicates that the PR was contributed by an external member. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/doing This PR's assignee is translating this PR.
Projects
2024 TiDB Docs Dash Issue List | 2024 TiDB 文档挑战赛任务列表
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug TiDB Cloud Documentation: Connect to TiDB with DBeaver
4 participants
@enkilee @Icemap @dveeden @qiancai