Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pps toml header leaking after zeroing positions #472

Closed
jaredgoldman opened this issue Feb 28, 2023 · 1 comment
Closed

Pps toml header leaking after zeroing positions #472

jaredgoldman opened this issue Feb 28, 2023 · 1 comment
Labels
accounting prolly positioning: the accounting of "what/when (is) owned" bug guille broke it prolly clearing auction and mm tech: EMS, OMS, algo-trading

Comments

@jaredgoldman
Copy link
Contributor

jaredgoldman commented Feb 28, 2023

When a user enters a position, stops the service tree and then boots it back up and zeroes the pp, the header for the position i.e [binance.paper] is leaked. It might have to do with the way we're loading the pps when booting up the paper actor to update UI slotting but by default we shouldn't be writing on that call. The expected behavior is that once a position is cleared, no record will appear in a user's pps.toml.

For context, these issues were reported in #462

@goodboy goodboy added clearing auction and mm tech: EMS, OMS, algo-trading accounting prolly positioning: the accounting of "what/when (is) owned" bug guille broke it prolly labels Feb 28, 2023
@goodboy
Copy link
Contributor

goodboy commented May 24, 2023

Pretty sure this was mostly resolved prior to #489 but either way it's solved by that for sure since we're no longer doing mult-broker pps files and instead each broker account has it's own account...toml file now B)

@goodboy goodboy closed this as completed May 24, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accounting prolly positioning: the accounting of "what/when (is) owned" bug guille broke it prolly clearing auction and mm tech: EMS, OMS, algo-trading
Projects
None yet
Development

No branches or pull requests

2 participants