-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DSA with multiple strategies apparently causes mixup in variable naming #332
Comments
I had a thorough check, and pretty much all of the parameter values are out of place. Below, I indicate after each row which parameter the value belongs to:
It would be useful to know, for a work-around, whether these values are only used for the labels on the tornado charts, or if they are also used as part of the plots or the underlying calculations? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This one is relatively complex to explain. I have a HEEMOD model with three strategies. I am running DSA with eight parameters, and ask the plot to evaluate parameter values.
The plot produces three tornado charts. The first one shows values for one parameter that this parameter never has:
![image](https://user-images.githubusercontent.com/44625260/50033300-d7f19300-ffef-11e8-96db-35a19016f415.png)
As shown in the table below, GMA only ever has values <1.0:
A similar thing happens for plot #3:
![image](https://user-images.githubusercontent.com/44625260/50033372-29018700-fff0-11e8-9849-5ca52405f598.png)
And as can be seen, the MRA parameter never assumes values other than <1.0:
I therefore inspected the printed result of the DSA, and noticed the following (** added to highlight parameter names and (wrong) values):
So somehow the evaluated values for some of my parameters are being mixed up. All of the 181323 and 543969 values should be associated with the "AnnualInflow = .." parameters, i.e. first six rows in the printout just above. I haven't checked whether all other parameters are correct, these examples jump out because they are large numbers, but a few of the I can immediately tell are not right, e.g:
<- The value of GMA is constant, so of course 0.25*getModerate... and 4*getModerate... should be the same values.
Possibly importantly, many of the parameters depend on model time, and have separate values for each cycle (see the parameter table above). I have not used the model_time variable to create these parameters with simple arithmetic (as in many heemod examples), but defined these parameters using arrays of type numeric(..) and size = model time horizon. The parameter values shown for "AnnualInflow = ..." are the evaluated values for the fist model year (0.5 * 362,646).
Of course, it may be just a simple ordering issue...
The text was updated successfully, but these errors were encountered: