-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lncorrect PHPDoc tags for stubs (e.g. acf_get_field_types, acf_get_setting) #9
Comments
Yes. This is not a selling point of ACF Pro, so these tags are slowly improving. All I have is this. Lines 27 to 43 in 3f02988
Related #8 and many more. What do you suggest? |
I don't really have a suggestion, I just noted that |
Yes, Paul did it with his hands, line by line. I would be very happy if you figure out a mechanism to fix the docblock of daily used functions. |
No! My mistake. Paul also used |
...after a bit of thinking. Please try to talk to Elliot. Maybe he accepts a patch. Last time I talked to him 🤣 he told me that applying my patch would fix all docblocks and he prefers fixing source code and docblocks at the same time, so he did not apply it. |
@mundschenk-at All right. Please provide me that one file ( |
@mundschenk-at Did a series of releases but still no improvement on "your" front. Many docblocks have improved in v6.0.7...v6.1.0 but not in these reported functions. |
Using |
You could download https://patch-diff.githubusercontent.com/raw/php-stubs/acf-pro-stubs/pull/8.patch and apply it as a patch. |
Ended up using composer-patches:~1.0 to apply a patch (on Generated the patch with this command:
I tried using symplify/vendor-patches, but couldn't get the patch to apply. |
Unfortunately the included PHPDoc tags for several functions are incorrect, for example
@return void
foracf_get_field_types
andacf_get_setting
).The text was updated successfully, but these errors were encountered: