Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stream support #194

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add Stream support #194

wants to merge 1 commit into from

Conversation

skerit
Copy link

@skerit skerit commented Sep 20, 2017

Code needs a little work, but I'd love to know what you'd think about adding a Stream source.

It might be fairly trivial to add your own custom sources, but it would be nice to be able to do:

var player = new JSMpeg.Player(my_stream);

or

var player = new JSMpeg.Player(null, {source: JSMpeg.Source.Stream});
player.source.setStream(my_stream);

This would add support for streams from browserify or socket.io-stream.

There's also a native stream standard in the works for Javascript, it's currently only supported in Chrome but it might be interesting to incorporate that, too?

And by the way: great job on the rewrite. Using a TS makes much more sense and I'm finally rid of annoying artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant