Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Use Instance Metadata Service Version 2 by default. #3513

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

dylanmtaylor
Copy link
Contributor

@dylanmtaylor dylanmtaylor commented Sep 29, 2023

This closes #3512.

@dylanmtaylor
Copy link
Contributor Author

We are running this module in production with this set and it works perfectly fine.

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, can you apply the cahnge to the mult-runner moduel as well

modules/runners/variables.tf Show resolved Hide resolved
@dylanmtaylor
Copy link
Contributor Author

Thanks, can you apply the cahnge to the mult-runner moduel as well

@npalm This is ready for re-review.

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dylanmtaylor Thanks and sorry for the delay. Changes is checked and all good.

@npalm npalm merged commit d8d69c3 into philips-labs:main Oct 19, 2023
19 checks passed
@dylanmtaylor dylanmtaylor deleted the idmsv2 branch October 19, 2023 15:27
npalm pushed a commit that referenced this pull request Oct 19, 2023
🤖 I have created a release *beep* *boop*
---


##
[4.6.0](v4.5.1...v4.6.0)
(2023-10-19)


### Features

* Use Instance Metadata Service Version 2 by default.
([#3513](#3513))
([d8d69c3](d8d69c3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: forest-releaser[bot] <80285352+forest-releaser[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IMDSv2 should be required by default
2 participants