Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): Add support for X-Ray tracing #3142

Merged
merged 15 commits into from
Apr 20, 2023

Conversation

mcaulifn
Copy link
Contributor

Add support for x-ray

@mcaulifn
Copy link
Contributor Author

@npalm Not sure what is up with the tfdocs workflow

@koendelaat
Copy link
Collaborator

@npalm Not sure what is up with the tfdocs workflow

I was facing the same issue.
I've resolved it here: e70bf2f

@npalm
Copy link
Member

npalm commented Mar 31, 2023

I recently move the update of the tfdocs to the release branch. But this conflicts with the pre-commit hook with tfdocs. So therefore I removed the pre-commit. And run the workflow on the PR. But that seems not working. Will dig in next week.

@npalm npalm self-requested a review April 5, 2023 04:42
Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, will check in detail later. But it seems you missed the pool lambda, which is in as submodule of the runners.

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcaulifn thx, I ran a quick test and only see tracing for the scale-down, not for the scale-up. Need to dig in a bit more next wee.

Besides that can you also add the tracing variable to multi-runner module.

@mcaulifn
Copy link
Contributor Author

Added to multi- and pool.

Copy link
Member

@npalm npalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and got a working with some tweaks:

  • multi-runner module file runner-binaries.tf add lambda_tracing_mode = var.lambda_tracing_mode
  • multi-runner module file webhook.tf add lambda_tracing_mode = var.lambda_tracing_mode
  • missed a policy for the pool see inlince comment.

changes also available on branch https://github.com/philips-labs/terraform-aws-github-runner/tree/mcaulifn/xray

modules/runners/pool/main.tf Show resolved Hide resolved
@npalm
Copy link
Member

npalm commented Apr 20, 2023

Tested and got a working with some tweaks:

  • multi-runner module file runner-binaries.tf add lambda_tracing_mode = var.lambda_tracing_mode
  • multi-runner module file webhook.tf add lambda_tracing_mode = var.lambda_tracing_mode
  • missed a policy for the pool see inlince comment.

changes also available on branch https://github.com/philips-labs/terraform-aws-github-runner/tree/mcaulifn/xray

@mcaulifn just pushed my addition to your branch

@npalm npalm merged commit 998a0d1 into philips-labs:main Apr 20, 2023
@mcaulifn mcaulifn deleted the mcaulifn/xray branch April 20, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants