Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 'reshapes' mechanism #56

Open
phausamann opened this issue Aug 31, 2020 · 0 comments
Open

Refactor 'reshapes' mechanism #56

phausamann opened this issue Aug 31, 2020 · 0 comments

Comments

@phausamann
Copy link
Owner

The reshapes parameter is confusing and in reality only necessary if the number of dimensions changes.

Proposal:

  1. Check if number of dimensions has changed, if yes check for reshapes parameter and raise error if not specified.
  2. Otherwise check if size of axes/dimensions have changed and drop coords accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@phausamann