Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone equality check of wrapped estimator fails for some types of parameters #43

Open
phausamann opened this issue Aug 1, 2018 · 0 comments
Labels
Milestone

Comments

@phausamann
Copy link
Owner

This is going to be a serious issue as of sklearn version 0.20 because clone will raise an exception. The only workaround is to use wrap with compat=True.

This seems to happen for tuples, lists and ndarrays, among others.

import numpy as np
from sklearn_xarray import wrap
from sklearn.base import clone
from sklearn.decomposition import DictionaryLearning

dl = wrap(DictionaryLearning(dict_init=np.ones((100, 100))))
clone(dl)
@phausamann phausamann added the bug label Aug 1, 2018
@phausamann phausamann added this to the Release 1.0 milestone Aug 1, 2018
@phausamann phausamann modified the milestones: Release 1.0, Release 0.3 Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant