Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize internal method names #35

Open
phausamann opened this issue Jan 31, 2018 · 0 comments
Open

Standardize internal method names #35

phausamann opened this issue Jan 31, 2018 · 0 comments
Assignees
@phausamann
Labels
internal API
Milestone
Release 1.0

Comments

@phausamann
Copy link
Owner

For example, the EstimatorWrapper calls _transform for each variable/DataArray whereas the transformers in the preprocessing module call _transform for each group and _transform_var for each variable/DataArray.

There should be a unified syntax: _transform_array for variables/DataArrays and _transform_group for groups.
@phausamann phausamann added this to the Release 0.1.4 milestone Jan 31, 2018
@phausamann phausamann self-assigned this Jan 31, 2018
@phausamann phausamann modified the milestones: Release 0.1.4, Release 0.2 Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phausamann phausamann

Labels
internal API
Projects
None yet
Milestone
Release 1.0
Development

No branches or pull requests
1 participant
@phausamann