Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work on browsers with Gostery extension #30

Open
davidbludlow opened this issue Jul 17, 2019 · 3 comments
Open

Doesn't work on browsers with Gostery extension #30

davidbludlow opened this issue Jul 17, 2019 · 3 comments

Comments

@davidbludlow
Copy link

davidbludlow commented Jul 17, 2019

Gostery ( https://www.ghostery.com/ ) is the world's leading anti-tracking tool (at least, according to this). It has browser extensions for all the major browsers plus many less major ones.

Unless Gostery is uninstalled or disabled, vue-google-signin-button
will never fire its success or error events, making it completely ineffective. When you click on the button it will show the google login page, then it will do nothing, leaving you logged out.

Gostery has an option to "Trust this site" but that doesn't help at all.

@davidbludlow
Copy link
Author

I think may have found some clues as to the problem by looking at the behavior of edpuzzle.com and socrative.com when Ghostery is active. I don't think either of them use vue-google-signin-button, but I think the clues are still valuable. See https://www.screencast.com/t/ei7REiUPVBM .

@phanan
Copy link
Owner

phanan commented Jul 17, 2019

What this plugin does is actually only render the sign-in button, no more no less. It seems to me the problem lies on Ghostery side (I've never used it before btw).

@davidbludlow
Copy link
Author

I agree that it is Ghostery's fault, but this still makes the websites that use vue-google-signin-button appear at fault to the user. I am a web developer and it still took me 6 hours to figure out that telling Gostery to "Trust this site" wasn't enough, I needed to disable the plugin.

I propose that we gang up on Ghostery and try to convince them to change their code, or failing that, we figure out a way to detect when Ghostery is causing problems and warn the user to disable the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants