[Bug] \Phalcon\Mvc\Model\Query->addFrom() disregarding "with" argument

[kornerita]

Hi,

We can see in \Phalcon\Mvc\Model\Query here, that the with parameter is disregarded in the addFrom method, I believe than this line of code is missing (taken from the constructor where is not disregarded).

Regards,
Federico.

[sergeyklay]

@kornerita Good catch! Thank you

[kornerita]

No problem, I found it just browsing code hehe.

[sergeyklay]

Long story short. This feature was introduced at Jun 1, 2015 (3e43192) was removed at Aug 6, 2015 (3ca2504). Actually this feature was never used in stable releases.

We will not add this feature into 3.x branch and most likely will refactor QueryBuilder in 4.x branch. Thus I just mark (#13109) this feature as deprecated to avoid misunderstandings for future developers.

To see team's opinion about Eager Loading refer to: #1117 .

Thank you for the report, and for helping us make Phalcon better.