Skip to content
This repository has been archived by the owner on Mar 8, 2024. It is now read-only.

Add feature dynamically updating m3u8 and .ts source file #15

Merged
merged 4 commits into from
Oct 4, 2019
Merged

Add feature dynamically updating m3u8 and .ts source file #15

merged 4 commits into from
Oct 4, 2019

Conversation

vaultec81
Copy link
Collaborator

@vaultec81 vaultec81 commented Aug 30, 2019

Detailed in #12
ping @moshisushi :)

@pgc-13
Copy link
Owner

pgc-13 commented Aug 30, 2019

Thanks! Will have a proper look at this over the weekend :)

A quick first observation tho: I'm not sure about ignoring the package-lock.json file. As far as I know, the lock file is supposed to be committed: https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5

@vaultec81
Copy link
Collaborator Author

Yeah I saw that too. I saw that it wasnt committed in the first place so I decided not to add it. Generally speaking I haven't seen it committed alot in other projects.

@vaultec81
Copy link
Collaborator Author

ping @moshisushi

@pgc-13
Copy link
Owner

pgc-13 commented Oct 3, 2019

@vaultec81 Sorry I've had family business to take care of and not had time to look into this. Would you like to be added as a collaborator to this repo?

@vaultec81
Copy link
Collaborator Author

@moshisushi No worries. and sure thing.

@pgc-13
Copy link
Owner

pgc-13 commented Oct 3, 2019

@vaultec81 Cheers! Do you have an npm alias as well please so I can add you there as well?

@vaultec81
Copy link
Collaborator Author

@moshisushi yes I do, the same as GitHub so vaultec81. Thanks.

@pgc-13
Copy link
Owner

pgc-13 commented Oct 3, 2019

@vaultec81 great, you're added! knock yourself out :)

@vaultec81 vaultec81 merged commit 428ffd8 into pgc-13:master Oct 4, 2019
@balgarath
Copy link

@vaultec81 was wondering if you have an example of this being used? I'm trying to puzzle out using this for an hls livestream over ipfs

Thanks!

@vaultec81
Copy link
Collaborator Author

@balgarath Example use case would be in circumstances where you would want to actively update/live stream HLS chunks. Before this was merged, it was impossible to update a livestream on the fly. There still is a couple of things that need to be created for a full scale live streaming system to be viable. Eventual project to be worked on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants