-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embed static ressources into the ppl-utils binary. #2
Comments
I prefer to compile my own binaries, so how would this affect me? Keeping static files externally would mean that I wouldn't have to recompile the binary all that often. This could be implemented in a way where the releases(i.e. prebuilt binaries) or a separate branch use this system without touching the main branch. |
As a side note in relation to my previous comment, using something like Git or GitHub Desktop allows you to sync all files automatically, thus making it easier to update the entire local clone of the repository. |
This change would impact you negatively. Note however that compiling ppl-utils should be trivial. |
It is trivial to compile ppl-utils, which is why I'm not necessarily in favor of this change, though I understand the convenience of it. |
I really prefer the simplicity of having a single binary. |
I understand. It's annoying for most people to have to redownload the entire repository and release each time a small update is made to the Webassembly. |
The ppl-utils binary and the static files (pewpewlive-wasm.js, pewpewlive-wasm.wasm, pewpew.html) need to stay in sync.
To prevent user error it would be nice if the static files were stored in the binary.
Packr seems like it would do the job: https://github.com/gobuffalo/packr
[edit: Go 1.16 will support this natively! No need to use Packr]
The text was updated successfully, but these errors were encountered: