Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property road not populated in IInstruction object #31

Open
mkv123 opened this issue Apr 27, 2020 · 1 comment
Open

Property road not populated in IInstruction object #31

mkv123 opened this issue Apr 27, 2020 · 1 comment

Comments

@mkv123
Copy link

mkv123 commented Apr 27, 2020

Hi,

Thanks for making all these plugins to make it easy to try out different routing services.

Noticed that the "road" attribute is not poplated on the instruction object.

IInstruction defined here:
https://www.liedman.net/leaflet-routing-machine/api/#iinstruction

Relevant code here

https://github.com/perliedman/lrm-graphhopper/blob/master/src/L.Routing.GraphHopper.js#L221

Adding road: instr.street_name seems to do the trick.

PS: I know this is looking for a maintainer but thought I'd document it anyway.

@perliedman
Copy link
Owner

I think it might be that street_name was not available from GraphHopper's API when I originally wrote this code, but not sure actually.

Consider creating a PR with this change to get it included in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants