Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow DOM support for Ember #705

Closed
itsjwala opened this issue Jan 30, 2023 Discussed in #704 · 1 comment · Fixed by #706
Closed

Shadow DOM support for Ember #705

itsjwala opened this issue Jan 30, 2023 Discussed in #704 · 1 comment · Fixed by #706
Labels
🐛 bug Something isn't working

Comments

@itsjwala
Copy link
Contributor

Discussed in #704

Originally posted by c69-addepar January 25, 2023
Hi Team, @itsjwala ,

since 1.19.0-alpha.0, @percy/cli now supports Shadow DOM.

Unfortunately, the changes in that repo alone are not enough to enable support for Ember apps. See percy/cli#1165 (comment)

Happy to provide more details if needed.

CC: @mmun @aschenoni

@itsjwala itsjwala added the 🐛 bug Something isn't working label Jan 30, 2023
@c69-addepar
Copy link

Thank you so much @itsjwala ! We have confirmed that @percy/cli 1.19.2 + @percy/ember 4.0.2 work well with our code.

This allowed us to remove the fork of 1.0.3, and switch back to mainline Percy! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants