fix(📌): Pin Puppeteer to 3.1.x #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puppeteer 3.2 introduces breaking changes. Pinning to 3.1 is a temporary fix until the changes can be accounted for
wwilsman
pushed a commit
that referenced
this pull request
May 29, 2020
Puppeteer 3.2 introduces breaking changes. Pinning to 3.1 is a temporary fix until the changes can be accounted for
djones
pushed a commit
that referenced
this pull request
May 29, 2020
## [0.26.8](v0.26.7...v0.26.8) (2020-05-29) ### Bug Fixes * **📌:** Pin Puppeteer to 3.1.x ([#516](#516)) ([ab7dd29](ab7dd29))
|
This was reverted in Puppeteer 3.3.0. Perhaps worth updating? |
|
Hey @swissspidy! Thanks for pointing out the new release! I was hoping it'd be released yesterday, but I'll get a new version of agent out asap today to unpin puppeteer. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Puppeteer 3.2 introduces breaking changes by removing the EventEmitter API and not backporting all EventEmitter methods. This update causes agent to error because
page.removeAllListenersis no longer a method.Approach
Pinning to 3.1 is a temporary fix until the breaking changes can be accounted for or we migrate away from Puppeteer.