fix: Properly forward headers in asset cache #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDP returns multiple headers joined by newlines, however `request.respond` (used for cached responses) will hang if there are newlines in headers. This commit normalizes header values as arrays split on newlines.
Robdel12
force-pushed
the
rd/strip-newlines-from-cache-headers
branch
from
b91f28e
to
40fc420
Compare
djones
pushed a commit
that referenced
this pull request
May 18, 2020
## [0.26.6](v0.26.5...v0.26.6) (2020-05-18) ### Bug Fixes * Properly forward headers in asset cache ([#511](#511)) ([aa3ac45](aa3ac45))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
CDP returns multiple headers joined by newlines, however
request.respond(used for cached responses) will hang if there are newlines in headers. This commit normalizes header values as arrays split on newlines.