fix: Capture resources even when Puppeteer tab timesout #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the try/catches up so we can still capture the discovered resourses even if the `goto` times out.
wwilsman
approved these changes
May 18, 2020
delete-merged-branch
bot
deleted the
rd/capture-resources-even-when-ad-timeout
branch
|
I need a new laptop with a working keyboard ;) |
|
Excuses excuses, I see your branch name. ;p |
djones
pushed a commit
that referenced
this pull request
May 18, 2020
## [0.26.5](v0.26.4...v0.26.5) (2020-05-18) ### Bug Fixes * Capture resources even when Puppeteer tab times out ([#510](#510)) ([8a39366](8a39366))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This splits the try/catches up so we can still capture the discovered resources even if the
gototo the dom snapshot times out.