fix: Up default network idle timeout to 125 #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have made huge speed & reliability improvements to the asset discovery process. Upping the timeout to 125 for more reliable baseline asset discovery shouldn't be an issue. Especially now that asset discovery response caching is enabled by default for all builds now.
wwilsman
reviewed
Apr 3, 2020
| @@ -48,7 +48,7 @@ OPTIONS | |||
| -c, --config=config Path to percy config file | |||
| -h, --allowed-hostname=allowed-hostname Allowable hostname(s) to capture assets from | |||
| -p, --port=port [default: 5338] Port | |||
| -t, --network-idle-timeout=network-idle-timeout [default: 50] Asset discovery network idle timeout (in milliseconds) | |||
| -t, --network-idle-timeout=network-idle-timeout [default: 125] Asset discovery network idle timeout (in milliseconds) | |||
There was a problem hiding this comment.
I think this whole file will automatically update before the bot releases a new version. And I believe it will also exclude those See code: sections.
There was a problem hiding this comment.
Yeah it does, it'll get updated again. I just ran oclif-dev readme locally too.
Forgot it was going to update as soon as its merged 🤦♂
djones
pushed a commit
that referenced
this pull request
Apr 3, 2020
## [0.26.2](v0.26.1...v0.26.2) (2020-04-03) ### Bug Fixes * Up default network idle timeout to 125 ([#495](#495)) ([1048848](1048848))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
We have made huge speed & reliability improvements to the asset discovery process. Upping the timeout to 125 for more reliable baseline asset discovery shouldn't be an issue. Especially now that asset discovery response caching is enabled by default for all builds now.