fix: snapshot & upload sort dry-run output #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
approved these changes
Apr 1, 2020
djones
pushed a commit
that referenced
this pull request
Apr 1, 2020
## [0.26.1](v0.26.0...v0.26.1) (2020-04-01) ### Bug Fixes * sort dry-run output ([#494](#494)) ([ae36f5a](ae36f5a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Tests show that dry run output can sometimes be flakey due to sort order.
Approach
Rather than fix the test, this sorts the output. Having the output be sorted will help people iterate on globs so you don't have to search the list to find if something was selected by the glob or not.
Tests were already assuming the output was sorted, so this should result in no more flakes for this test.