feat: snapshot and upload --dry-run flag #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones
pushed a commit
that referenced
this pull request
Mar 17, 2020
# [0.26.0](v0.25.0...v0.26.0) (2020-03-17) ### Features * snapshot and upload --dry-run flag ([#486](#486)) ([6e259a3](6e259a3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When honing in your file globs for the
uploadandsnapshotcommands, it can be exhaustive to keep creating new Percy builds. This adds a--dry-run(or-d) flag to both commands which will not create a new Percy build and print the list of matching paths.Approach
For the
snapshotcommand, the snapshot service is responsible for parsing the paths. At that point in the command execution, a build has already been created and the local server started. The resulting paths also have the localhost URL and port attached which is not desirable for printing just the paths. For this command, the glob parsing was copy and pasted into another command method which is called when--dry-runis provided.For the
uploadcommand, the build is created after glob parsing. So we can safely handle the--dry-runparameter in thesnapshotAllmethod and exit early after printing matching paths.There were no unit tests for the
uploadcommand so thesnapshotcommand tests were copied over and adjusted accordingly.