Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Log out snapshot options in debug logs #480

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

Robdel12
Copy link
Contributor

@Robdel12 Robdel12 commented Mar 6, 2020

Super helpful for debugging:

[percy] -> widths: 375,1200
[percy] -> minHeight: 1024
[percy] -> enableJavaScript: undefined
[percy] -> requestHeaders: undefined
[percy] -> percyCSS: .percy-only-css-global {
  height: 300px;
  width: 300px;
  background-color: blue;
}```

@Robdel12 Robdel12 requested a review from wwilsman March 6, 2020 20:51
@wwilsman
Copy link
Contributor

wwilsman commented Mar 6, 2020

Or rather than stringify or inspect, we could follow the same pattern from above and break the options apart.

snapshotLogger.debug(`-> widths: ${snapshotOptions.widths}`)
snapshotLogger.debug(`-> minHeight: ${snapshotOptions.minHeight}`)
snapshotLogger.debug(`-> enableJavaScript: ${snapshotOptions.enableJavaScript}`)
snapshotLogger.debug(`-> requestHeaders: ${snapshotOptions.requestHeaders}`)
snapshotLogger.debug(`-> percyCSS: ${snapshotOptions.percyCSS}`)

I'm okay with either way, just throwing out options

Super helpful for debugging
Copy link
Contributor

@wwilsman wwilsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎮

@Robdel12 Robdel12 merged commit c524926 into master Mar 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the rd/log-passed-options branch March 6, 2020 22:33
djones pushed a commit that referenced this pull request Mar 6, 2020
## [0.24.3](v0.24.2...v0.24.3) (2020-03-06)

### Bug Fixes

* Log out snapshot options in debug logs ([#480](#480)) ([c524926](c524926))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants