feat: add meta information to healthcheck endpoint #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
changed the title
n2o1988
approved these changes
Mar 2, 2020
djones
pushed a commit
that referenced
this pull request
Mar 2, 2020
# [0.24.0](v0.23.0...v0.24.0) (2020-03-02) ### Features * **:sparkles::** add meta information to healthcheck endpoint ([#470](#470)) ([c67ed5a](c67ed5a))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
It might be useful for third part SDKs or even our own SDKs in the future to be able to query the server for some meta information. For now this is limited to build number and URL but could be expanded to include SDK options passed through from the CLI or config file.
Approach
Add meta to the healthcheck response and test it.
I noticed that other requests in this file were not awaited on, so they were updated accordingly.