fix: clamp image dimensions to min and max for snapshot width and minHeight options #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... why are there new snapshots and a missing one? They should all be there 🤔 |
|
Not sure why the logo is missing, but the new snapshots are because the width is now 812px |
Robdel12
suggested changes
Jan 31, 2020
wwilsman
commented
Jan 31, 2020
When we render on our side, the full image should still be captured.
wwilsman
force-pushed
the
ww/clamp-image-upload-dimensions
branch
from
24b1e4f
to
d16183f
Compare
wwilsman
changed the title
djones
pushed a commit
that referenced
this pull request
Jan 31, 2020
## [0.20.13](v0.20.12...v0.20.13) (2020-01-31) ### Bug Fixes * clamp image dimensions to min and max ([#460](#460)) ([ca68b0f](ca68b0f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
#459 brought to light that sometimes image dimensions might be outside of the bounds of our min and max for snapshots.
Approach
Clamp both width and height to between 10px - 2000px, but for snapshot options
widthsandminHeightonly as the image in the DOM should contain the correct width and height.When we render on our side, the full image should still be captured.
TODO