fix: remove TypeScript types from dependencies #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones
pushed a commit
that referenced
this pull request
Dec 18, 2019
## [0.20.6](v0.20.5...v0.20.6) (2019-12-18) ### Bug Fixes * remove TypeScript types from dependencies ([#439](#439)) ([37bf691](37bf691))
|
TypeScript explicitly encourage listing type definitions for runtime dependencies under The reason being that otherwise consumers of your package who do use TypeScript don't get the type definitions installed, and won't be able to use any types from your dependencies that you expose. The dependency is essentially "free" for people who don't use TypeScript, as the code ends up just sitting in |
wwilsman
pushed a commit
that referenced
this pull request
Jan 21, 2020
wwilsman
pushed a commit
that referenced
this pull request
Jan 21, 2020
## [0.20.6](v0.20.5...v0.20.6) (2019-12-18) ### Bug Fixes * remove TypeScript types from dependencies ([#439](#439)) ([37bf691](37bf691))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when installing
@percy/agentthat myyarn.locksuddenly had some TypeScript definitions in it, despite me not using TypeScript.I believe that the
@types/whichpackage should actually be adevDependency, rather than adependency. Otherwise, all of your users have to install these type definitions along with your package!