Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add context to log output on finalize error #436

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

wwilsman
Copy link
Contributor

Purpose

Merged #435 a little fast for some PR feedback

Approach

Adds some context to the log output on finalize as @timhaines suggested.

Copy link
Contributor

@timhaines timhaines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@Robdel12 Robdel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

@wwilsman wwilsman merged commit f582027 into master Dec 11, 2019
@wwilsman wwilsman deleted the ww/finalize-error-context-log branch December 11, 2019 20:59
djones pushed a commit that referenced this pull request Dec 11, 2019
## [0.20.5](v0.20.4...v0.20.5) (2019-12-11)

### Bug Fixes

* add context to log output on finalize error ([#436](#436)) ([f582027](f582027))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants