fix: assets loading issues #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add check to ensure that requests with 'other' resource type; with an empty response body are skipped. The `shouldRequestResolve` in `asset-discovery-service` is used to capture resource hints in older chromium versions. Cypress versions < 3.5.0 used chrome 61 whilst above versions have upgraded to 73. In chrome 61 the resource hint type requests recieved the request purpose in he header. In future versions, confirmed 73+, this header is not sent. In newer chrome versions we can check the request `resourceType`; if of type 'other' and with an empty response body we can skip the handling of this request.
djones
pushed a commit
that referenced
this pull request
Dec 9, 2019
## [0.20.3](v0.20.2...v0.20.3) (2019-12-09) ### Bug Fixes * assets loading issues ([#434](#434)) ([4028538](4028538))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check to ensure that requests with 'other' resource type; with an
empty response body are skipped.
The
shouldRequestResolveinasset-discovery-serviceis used to captureresource hints in older chromium versions. Cypress versions < 3.5.0 used
chrome 61 whilst above versions have upgraded to 73.
In chrome 61 the resource hint type requests recieved the request
purpose in he header. In future versions, confirmed 73+, this header is
not sent.
In newer chrome versions we can check the request
resourceType; if oftype 'other' and with an empty response body we can skip the handling of
this request.