fix: Always release puppeteer page in asset discovery #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a chance an error happens and then the page is never cleaned up. This hangs the process open for ever.
wwilsman
reviewed
Oct 9, 2019
Robdel12
force-pushed
the
rd/release-puppteer-page-on-error
branch
from
16f29da
to
43420e1
Compare
wwilsman
reviewed
Oct 9, 2019
wwilsman
approved these changes
Oct 9, 2019
|
🎮 |
djones
pushed a commit
that referenced
this pull request
Oct 9, 2019
## [0.19.1](v0.19.0...v0.19.1) (2019-10-09) ### Bug Fixes * Always release puppeteer page in asset discovery ([#396](#396)) ([6e4cff1](6e4cff1))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
There's a chance an error happens and then the page is never cleaned up. This
hangs the process open for ever.