fix: Encode image url for static image uploads #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djones
pushed a commit
that referenced
this pull request
Oct 3, 2019
## [0.17.1](v0.17.0...v0.17.1) (2019-10-03) ### Bug Fixes * 🐛 Encode image url for static image uploads ([#385](#385)) ([6a52a9c](6a52a9c))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Images with a space in the name fail to capture properly. We should encode the image URL so that and other characters do not fail to capture.
Approach
Use
encodeURIComponentto encode the image path as a url. Use that url for the image resource, and also encode the root resource URL as well.Tests
Renamed the static
percy.jpgfile topercy home.jpgto test that the space is properly encoded. If Percy captures the snapshot, the test passes.