fix: Handle 404 errors when capturing redirected assets #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
approved these changes
Sep 25, 2019
delete-merged-branch
bot
deleted the
rd/redirect-asset-error-handling
branch
djones
pushed a commit
that referenced
this pull request
Sep 25, 2019
## [0.16.1](v0.16.0...v0.16.1) (2019-09-25) ### Bug Fixes * Handle 404 errors when capturing redirected assets ([#354](#354)) ([aefcd17](aefcd17))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Turns out redirected assets that 404 can break asset discovery, who knew?
😆
This PR wraps the network call in try/catch (like it always should have been) and handles redirected assets that 404 properly now.