fix: Add Percy specific CSS to root resource after asset discovery #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwilsman
reviewed
Sep 24, 2019
Robdel12
force-pushed
the
rd/log-percy-css
branch
from
af45aa3
to
1903da1
Compare
wwilsman
approved these changes
Sep 24, 2019
Robdel12
changed the title
wwilsman
reviewed
Sep 24, 2019
wwilsman
approved these changes
Sep 24, 2019
Robdel12
force-pushed
the
rd/log-percy-css
branch
from
9846a90
to
97ccaf6
Compare
Before, it's possible the asset discovery resource saves the CSS as a different content type (for example, if their server just serves the root index for this request, we would get DOM instead of CSS)
Robdel12
force-pushed
the
rd/log-percy-css
branch
from
97ccaf6
to
6e23317
Compare
Robdel12
force-pushed
the
rd/log-percy-css
branch
from
b27038d
to
0d1cdca
Compare
wwilsman
reviewed
Sep 24, 2019
| rootResourceUrl, | ||
| domSnapshot, | ||
| options, | ||
| logger, | ||
| ) | ||
| } |
There was a problem hiding this comment.
This method no longer seems useful. Could leave it as an alias, or just call this.snapshotService.assetDiscoveryService.discoverResources directly from the agent service.
There was a problem hiding this comment.
Yeah for sure, going to clean that up in future PRs
wwilsman
approved these changes
Sep 24, 2019
djones
pushed a commit
that referenced
this pull request
Sep 24, 2019
## [0.15.2](v0.15.1...v0.15.2) (2019-09-24) ### Bug Fixes * Add Percy specific CSS to root resource after asset discovery ([#352](#352)) ([5984a65](5984a65))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
While debugging some percy CSS weirdness I thought it would be pretty nice to see in the logs when this is created and if its skipped, why?