fix: Check for widths array length so empty arrays are never used #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
force-pushed
the
rd/check-for-empty-widths
branch
from
a753609
to
64142a8
Compare
If you pass an empty array from and SDK, the asset discovery service blows up. We should just fall back to the default widths
Robdel12
commented
Sep 20, 2019
| @@ -96,9 +96,10 @@ export class AgentService { | |||
| const configuration = new ConfigurationService().configuration | |||
| // trim the string of whitespace and concat per-snapshot CSS with the globally specified CSS | |||
| const percySpecificCSS = configuration.snapshot['percy-css'].concat(request.body.percyCSS || '').trim() | |||
| const hasWidths = !!request.body.widths && request.body.widths.length | |||
There was a problem hiding this comment.
It's real annoying that !![] is true in JS
wwilsman
approved these changes
Sep 20, 2019
djones
pushed a commit
that referenced
this pull request
Sep 20, 2019
## [0.15.1](v0.15.0...v0.15.1) (2019-09-20) ### Bug Fixes * Check for widths array length so empty arrays are never used ([#351](#351)) ([e044749](e044749))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
If you pass an empty array from and SDK, the asset discovery service blows up. We should just fall back to the default widths