feat: Capture redirected assets #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axios will follow the redirect chain for us, so we can just request the asset and get the content back. Then save that content with the original requests URL.
Robdel12
commented
Sep 19, 2019
wwilsman
reviewed
Sep 19, 2019
Robdel12
commented
Sep 19, 2019
wwilsman
reviewed
Sep 19, 2019
wwilsman
reviewed
Sep 19, 2019
|
Would this be a feature? Are we fixing redirects, or adding support for redirects? 🤷♂ |
wwilsman
approved these changes
Sep 19, 2019
Robdel12
changed the title
|
I'd say it's a feature tbh. Updated the title 👍 |
djones
pushed a commit
that referenced
this pull request
Sep 19, 2019
# [0.15.0](v0.14.1...v0.15.0) (2019-09-19) ### Features * Capture redirected assets ([#349](#349)) ([aa918cc](aa918cc))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This PR introduces the ability to capture assets that are discovered, but have a redirect chain. Currently agent will skip these assets since it's not super easy to follow the chain all the way through and then capture that asset in Puppeteer.
Approach
The redirected resources are captured by requesting the redirected URL with
axiosfrom Node. This will properly follow the redirect chain for us, then we save the response body of that request as the original request URL (so it proxy's correctly in our rendering env).While doing this I refactored the methods for capturing resources to their respective paths now. Normal assets from the asset discovery service using puppeteer now process their resource and redirected resources are not processed via Node.
TODOs
featorfix?