feat: Allow wildcard hostnames #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
reviewed
Sep 18, 2019
|
RIP. The asset wasn't captured. Let me see why locally |
Robdel12
reviewed
Sep 18, 2019
wwilsman
commented
Sep 18, 2019
wwilsman
force-pushed
the
ww/allow-wildcard-hostnames
branch
from
2a99a7f
to
bf25dc3
Compare
|
Unrelated, it looks like the CSSOM test flaked in one of the CI runs 🤔 |
|
Oh weird, that looks like the live site failed to be requested or something 🤔 Another case for #304 |
wwilsman
force-pushed
the
ww/allow-wildcard-hostnames
branch
from
bf25dc3
to
06b3a28
Compare
|
The domain-match package had an issue where it was comparing hosts including the port number. Updated the approach (and PR description) to copy the small util over and update it to not use the port number. @Robdel12 could you re-review, including that new util file? |
Robdel12
approved these changes
Sep 18, 2019
wwilsman
added a commit
that referenced
this pull request
Sep 18, 2019
djones
pushed a commit
that referenced
this pull request
Sep 18, 2019
# [0.14.0](v0.13.0...v0.14.0) (2019-09-18) ### Features * ✨ Allow wildcard hostnames ([#347](#347)) ([730161f](730161f))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When the subdomain of a hostname is variable, not known, or has many other subdomains, it is more concise to use a wildcard subdomain.
Approach
Attempted to use
domainMatchto compare the resource hostname with the allowed hostnames. However internally, the package usesparsedURL.hostwhich contains the port number and causes the check to fail. The source code was fairly small and straightforward, so I copied it here and adjusted it to usehostnamewhich does not contain the port number.Copying the small util here also made typescript happy about missing type defs.