feat: Support capturing assets from allowed hostnames #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhaines
changed the title
Robdel12
reviewed
Aug 7, 2019
| @@ -1,5 +1,4 @@ | |||
| import * as cheerio from 'cheerio' | |||
| import * as fs from 'fs' | |||
| it, and we start the integration tests by specifying localhost.me as an allowed-hostname | ||
| with the -h flag. | ||
| </p> | ||
| <img src="http://localtest.me:8000/vue.svg"> |
There was a problem hiding this comment.
Curious how this works in CI? Are we editing a host file to make this work?
There was a problem hiding this comment.
@Robdel12 no, localtest.me's dns entry points to 127.0.0.1. So in CI the node server we spin up that listens to 127.0.0.01:8000 works just the same way it does locally, with no configuration needed.
djones
pushed a commit
that referenced
this pull request
Aug 7, 2019
# [0.10.0](v0.9.2...v0.10.0) (2019-08-07) ### Features * Support capturing assets from allowed hostnames ([#320](#320)) ([c3fb8ac](c3fb8ac))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for allowed hostnames that assets should be captured from.
If a hostname is specified, any requests to assets on that hostname will be captured, and they'll be uploaded to Percy's API as snapshot resources. During rendering time, http requests to the captured asset's url will be hijacked, and the captured resource served.
Hostnames can be provided either with the
-allowed-hostnameor-hflag, or they can be specified in the.percy.ymlfile as an array under agent -> asset-discovery -> allowed-hostnames.The main function is tested with the new alternate-hostname integration test. It loads a vue.svg file from a hostname of localhost.me. Localhost.me resolves to 127.0.0.1, so we can serve it from our local dev/CI environment, and be sure that the captured asset is being served in production.
Note: requests to https assets won't be successfully highjacked in our rendering environment yet, but this PR should include the appropriate support for capturing them to our @percy/agent based SDKs.