Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Strip host from static snapshot names #250

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

Robdel12
Copy link
Contributor

What is this?

This will turn a snapshot name from http://localhost:5339/index.html to /index.html

This is so if anyone changes the hostname or port, it doesn't mess up their snapshot baseline

This will turn a snapshot name from `http://localhost:5339/index.html` to
`/index.thml`

This is so if anyone changes the hostname or port, it doesn't mess up their
snapshot baseline
@Robdel12 Robdel12 requested a review from djones June 14, 2019 23:11
Copy link
Contributor

@djones djones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍍 LGTM

@Robdel12 Robdel12 merged commit 9026073 into master Jun 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the rd/strip-host-from-static-snapshot-name branch June 14, 2019 23:17
djones pushed a commit that referenced this pull request Jun 14, 2019
## [0.7.2](v0.7.1...v0.7.2) (2019-06-14)

### Bug Fixes

* Strip host from static snapshot names ([#250](#250)) ([9026073](9026073))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants